-
Notifications
You must be signed in to change notification settings - Fork 137
Add internationalization support for human readable labels #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's sufficient to just state that dir
and lang
will, be added... we need to actually specify them properly, like saying if dir
will be an enum, and if an invalid language tag will throw (I guess that's part of whatwg/webidl#1025).
We can keep building on this pull request tho.
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
Here is a concrete plan:
|
@marcoscaceres, quick clarification regarding your plan. Are these steps you recommend after publication of the Rec with this pull request integrated? |
After Rec, as these are additions for a Recommendation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this approach. I don't think I agree with Marcos' comment that we need to include how lang
and dir
would work in detail at this point, but I might be persuaded if you can explain your reasoning @marcoscaceres :)
(I also don't mind if we do include details, if Ian wants to do the extra work.)
So, we wouldn't merge this until after REC, and we would only merge this if our group's criteria is met: we would fully spec this out, add tests, and get implementation commitment (same as any feature we've added to the spec in the past). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this covers the need to call out a potential change while we figure out whether to make it and what form it should take.
Based on joint I18N/WPWG discussion today [1] I anticipate that we will not add dir/lang to Payment Request. I believe there is now support for publishing the Recommendation with informative hooks that indicate that internationalization for these two strings needs to be fixed and that we are part of a Web community discussion about how to do that with a platform-wide solution. I took an action to work with @r12a on text for the specification. |
@r12a and @aphillips, I have updated this pull request based on the 26 Oct joint discussion. Per @r12a's comments during the meeting, I have characterized this as (1) a fix and (2) pending progress on the platform wide solution. I welcome your review of this and any suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m approving these, but I’d like to go on the record that I disagree with the additions as they might set false expectations for readers.
I am broadly supportive of i18n solutions, but if OS-level payment handlers don’t ever end up supporting dir/lang (and there is no implementation backing), then there is not much the W3C or working group can do about that (we can “recommend” things, but we can’t force anyone to implement them).
I hope that changes in the future through real-world demand. I would have preferred we continue to advocate for the better i18n support as we’ve done with other features in this specification: through close collaboration with implementers and sites/services that are deploying the API at scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The I18N WG reviewed this PR in our teleconference of 2021-11-04 and I drew an action item to approve it.
@aphillips, many thanks to you and the I18N Working Group for working with us on this and other issues. We really do appreciate the engagement. |
The Internationalization Working Group has raised concerns about lack of Internationalization support for two strings in the specification (see issues #948 and #951).
I agree that the specification should support internationalization.
I believe the following is deployment reality:
Summary: In practice these strings are used almost exclusively used by the Google Pay and Apple Pay native apps.
Other observations:
Given this context, the current pull request seeks a balance:
[Added after posting: if people disagree with the above characterization, please weigh in on that. Thanks!]
I look forward to feedback from @aphillips, @r12a, and the Internationalization Working Group, as well as @marcoscaceres, @stephenmcgruer, @rsolomakhin, and @nickjshearer.
[1] https://www.w3.org/2020/Process-20200915/#candidate-addition
The following tasks have been completed:
Implementation commitment:
Preview | Diff