-
Notifications
You must be signed in to change notification settings - Fork 20
Mention layout mirroring for bidi #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! Thank you for taking this on.
So far so good. I guess you know that you'll need to add the bidi_user_interface label for the related review comments link to work. |
index.html
Outdated
|
||
<p>When content is displayed in a right-to-left language context, user agent-provided UI controls should automatically mirror their layout. This includes reversing directional icons, repositioning control elements (such as the "on" position in toggle switches), and other spatial arrangements that have inherent directional meaning.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directional icons are not normally reversed automatically. Are you sure you want to say that? It's not necessarily clear whether or not an icon needs to be reversed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, sometimes we need to mirror and sometimes not. I adjusted the text. Thanks.
index.html
Outdated
|
||
<p>It is typical, when localizing a user interface or web page, to create mirror-images for the RTL and LTR versions. For example, it is likely that a box that appears near the left side of a window containing English content would appear near the right side of the window if the content is Arabic or Hebrew. It should preferably automatic for this to change, based on the base direction of the current context, unless there is a strong reason for using absolute geometry. One way to achieve this is to use keywords such as <code class="kw" translate="no">start</code> and <code class="kw" translate="no">end</code>, rather than <code class="kw" translate="no">left</code> and <code class="kw" translate="no">right</code>, to indicate position.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to repeat the layout related aspects of the previous mustard.
It seems to actually be saying that logical property values should be available, rather than fixed direction ones. If that's the case, then you should probably say that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Preview | Diff