Skip to content

PackageDeploymentManager: IsReadyOrNewerAvailable(), FrameworkUdk update, Implement not-implemented functions, Tests! #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 88 commits into from
Jun 25, 2024
Merged

PackageDeploymentManager: IsReadyOrNewerAvailable(), FrameworkUdk update, Implement not-implemented functions, Tests! #4453

merged 88 commits into from
Jun 25, 2024

Conversation

DrusTheAxe
Copy link
Member

@DrusTheAxe DrusTheAxe commented May 28, 2024 •
edited
Loading

This PR does multiple things

  • Add contract version 2
    • Is*ReadyOrNewerAvailable*()
    • EnsureReadyOptions.RegisterNewerIfAvailable=bool
    • Is*Provisioned*()
  • Fix progress updates when PackageSet.Items.Count>=2 (was (re)set to 0-1.0 for each item, not collectively for the whole operation)
  • Update to recent FrameworkUdk
  • Implement previously not-implemented functions (Remove, Repair, Reset)
  • Expanded test coverage
  • Updated TAEF to 10.92.240405002
  • Fixed DevCheck error accessing non-existent registry value if DeveloperMode was never set. Changed to use more resilient mechanism; this was the last of the older less-resilient syntax in the code

KNOWN ISSUES:

  1. Need updated Platform SDK to resolve known issues
  2. Register*Async() errors on 20H2/Vb3.
  3. Reset*Async() succeeds but ends w/o the package being registered
  4. RemovePackageByUriAsync() throws E_NOTIMPL
  5. RemovePackageSetAsync() throws E_NOTIMPL if PackageUri=ms-uup
  6. Provision*Async() not supported yet
  7. Deprovision*Async() not supported yet

https://task.ms/49555034
https://task.ms/48914090
https://task.ms/48964562
@DrusTheAxe
Added start of common errors / solutions
5d2a8a7
@DrusTheAxe
Added StringToSid() and SidToString()
44d8dc0
@DrusTheAxe
Added Is*ReadyOrNewerAvailable*(). Implemented RemovePackageByFullNam…
ff364b2 
…eAsync()m RemovePackageByFamilyNameAsync(), IsPackageRegistrationPending*(). Added tests for Register*(). Fix some test bugs.
@DrusTheAxe
Fixed parameter name
9b8b0ff
@DrusTheAxe
Incorporated API Review feedback
4734bbc
@DrusTheAxe
Fixed build error
1523bc6
@DrusTheAxe
Added Progress variants
25d78a7
@DrusTheAxe
Refactored common code into WaitForDeploymentOperation
c783711
@DrusTheAxe
Fixed progress reporting incorrect .progress percentage values
3135fd0
@DrusTheAxe
Merge branch 'main' into user/drustheaxe/pkgmgmt-fwudk-and-isreadyorn…
8548473 
…eweravailable
@DrusTheAxe
Bumped Microsoft.FrameworkUdk to latest 1.6.1-CI-27587.1000.240327-10…
ccb8ed6 
…00.0
@DrusTheAxe
Added more tests. Added IsPackageRegistrationPending. Removed dead co…
71dcb2c 
…de. Added Black+Blacker test Main packages.
@DrusTheAxe
Fixed Pending tests. Success!
a7c31e8
@DrusTheAxe
Updated FrUdk to the right version
5b7f878
@DrusTheAxe
Added PackageFamilyName() property to PackageIdentity
6b6aebd
@DrusTheAxe
Initial updates using Uup_*() from FrameworkUdk
8fbbb0b
@DrusTheAxe
Added IsPackageDeploymentFeatureSupported and initial support for Con…
cef87f6 
…tainment. More tests
@DrusTheAxe
Refactored test files in preparation of even more explosion
5bdef1b
@DrusTheAxe
Fixed RemovePackageOptions.FailIfNotFound. Added more tests
c92b718
@DrusTheAxe
Fixed RemovePackageSetAsync tests feature check
f1ae151
@DrusTheAxe
Added partial tests for Reset+Repair. Fixed IsPackage*Ready(pkgfullname)
5231072
@DrusTheAxe
Updated Is*ReadyOrNewerAvailable() using FrameworkUdk. Tests. Lots of…
0844d9f 
… tests...
@DrusTheAxe
Improved logging
774033f
@DrusTheAxe
Containment doesn't do what it seemed to do; changed to alternative m…
afb26c8 
…echanism. Figured out the FrameworkUdk problem; fixed up to build correctly but need a FrameoworkUdk turn
@DrusTheAxe
Updated the IsSupported machinery
c62a1d0
@DrusTheAxe
Refactored tests
b71c2cb
@DrusTheAxe
Merge branch 'main' into user/drustheaxe/pkgmgmt-fwudk-and-isreadyorn…
522d61a 
…eweravailable
@DrusTheAxe
Fixed up some logging. Improved IsSupported verification
c307ee1
@DrusTheAxe
Expanded tests. Fixed some PackageSet parameter validations. Fixed Re…
627df24 
…movePackageOptions.FailIfNotFound default (was true, supposed to be false). Mostly implemented RemovePackageSetAsync; URI handling is blocked awaiting FrameworkUdk update (imminent).
@DrusTheAxe
Updated to latest FrameworkUdk
875d4a0
@DrusTheAxe
Copy link
Member Author

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@DrusTheAxe
Copy link
Member Author

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@DrusTheAxe
Copy link
Member Author

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@DrusTheAxe
Copy link
Member Author

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@DrusTheAxe
Copy link
Member Author

/azp run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@DrusTheAxe DrusTheAxe merged commit c6c2234 into main Jun 25, 2024
24 checks passed
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/pkgmgmt-fwudk-and-isreadyorneweravailable branch June 25, 2024 20:52
kythant added a commit that referenced this pull request Jun 26, 2024
@kythant
Revert "PackageDeploymentManager: IsReadyOrNewerAvailable(), Framewor…
cab2db2 
…kUdk update, Implement not-implemented functions, Tests! (#4453)"

This reverts commit c6c2234.
@kythant kythant mentioned this pull request Jun 26, 2024
Merged
kythant added a commit that referenced this pull request Jun 27, 2024
@kythant
Revert "PackageDeploymentManager: IsReadyOrNewerAvailable(), Framewor…
684fdf1 
…kUdk update, Implement not-implemented functions, Tests! (#4453)" (#4514)

This reverts commit c6c2234.
DrusTheAxe added a commit that referenced this pull request Jun 27, 2024
@DrusTheAxe
Reapply "PackageDeploymentManager: IsReadyOrNewerAvailable(), Framewo…
1fe10da 
…rkUdk update, Implement not-implemented functions, Tests! (#4453)" (#4514)

This reverts commit 684fdf1.
kythant added a commit that referenced this pull request Jun 27, 2024
@kythant
Revert "Revert "PackageDeploymentManager: IsReadyOrNewerAvailable(), …
1db09ad 
…FrameworkUdk update, Implement not-implemented functions, Tests! (#4453)" (#4514)"

This reverts commit 684fdf1.
DrusTheAxe added a commit that referenced this pull request Jun 27, 2024
@DrusTheAxe
Package Management and IsReadyOrNewerAvailable() again (#4517)
9e53458 
* Reapply "PackageDeploymentManager: IsReadyOrNewerAvailable(), FrameworkUdk update, Implement not-implemented functions, Tests! (#4453)" (#4514)

This reverts commit 684fdf1.

* Added #include sddl.h as WindowsAppRuntime.sln was fine for all users but the WindowsAppRuntimeInstaller.sln wasn't. Better to be self-fulfilling in case code changes again in the future to avoid unknown-symbol pains
@DrusTheAxe DrusTheAxe mentioned this pull request Jul 12, 2024
Draft
@DrusTheAxe DrusTheAxe mentioned this pull request Jul 24, 2024
Merged
@codendone codendone mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Deployment Issues related to packaging, installation, runtime (e.g., SelfContained, Unpackaged)
2 participants
@DrusTheAxe @rhuang-msft