Groups

golang-codereviews

Contact owners and managers

1–30 of 103877

0 selected

Gerrit Bot (Gerrit), qiu laidongfeng (Gerrit)2

4:16 AM

[go] net: update document on limitation of iprawsock on Windows

Attention needed from Damien Neil and Ian Lance Taylor qiu laidongfeng voted Commit-Queue+1 Commit-

unread,

[go] net: update document on limitation of iprawsock on Windows

Attention needed from Damien Neil and Ian Lance Taylor qiu laidongfeng voted Commit-Queue+1 Commit-

4:16 AM

Dmitri Shuralyov (Gerrit), … qiu laidongfeng (Gerrit)6

4:15 AM

[go] cmd: remove dead code

Attention needed from Alan Donovan, Dmitri Shuralyov, Keith Randall, Martin Möhrmann and Robert

unread,

[go] cmd: remove dead code

Attention needed from Alan Donovan, Dmitri Shuralyov, Keith Randall, Martin Möhrmann and Robert

4:15 AM

Gerrit Bot (Gerrit), … qiu laidongfeng (Gerrit)3

Aug 2

[go] net/http: the server-side http Request Body is always non-nil

Attention needed from Damien Neil qiu laidongfeng voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] net/http: the server-side http Request Body is always non-nil

Attention needed from Damien Neil qiu laidongfeng voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Aug 2

qiu laidongfeng2 (Gerrit), … qiu laidongfeng (Gerrit)24

Aug 2

[go] all: remove support for windows/arm

Attention needed from Cherry Mui, Dmitri Shuralyov, Mark Freeman and Quim Muntal qiu laidongfeng

unread,

[go] all: remove support for windows/arm

Attention needed from Cherry Mui, Dmitri Shuralyov, Mark Freeman and Quim Muntal qiu laidongfeng

Aug 2

Cherry Mui (Gerrit)

Aug 2

[go] cmd/cgo/internal/test: use (syntactic) constant for C array bound

Attention needed from Ian Lance Taylor and Michael Pratt New activity on the change Open in Gerrit

unread,

[go] cmd/cgo/internal/test: use (syntactic) constant for C array bound

Attention needed from Ian Lance Taylor and Michael Pratt New activity on the change Open in Gerrit

Aug 2

Cherry Mui (Gerrit)

Aug 2

[go] cmd/internal/testdir: pass -buildid to link command

Attention needed from David Chase and Than McIntosh New activity on the change Open in Gerrit Related

unread,

[go] cmd/internal/testdir: pass -buildid to link command

Attention needed from David Chase and Than McIntosh New activity on the change Open in Gerrit Related

Aug 2

Cherry Mui (Gerrit)

Aug 2

[go] cmd/internal/testdir: unify link command

Attention needed from David Chase and Than McIntosh New activity on the change Open in Gerrit Related

unread,

[go] cmd/internal/testdir: unify link command

Attention needed from David Chase and Than McIntosh New activity on the change Open in Gerrit Related

Aug 2

Rachel (Gerrit), … David Chase (Gerrit)4

Aug 2

[arch] Revert "internal/simdgen: remove automatically generated tests"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[arch] Revert "internal/simdgen: remove automatically generated tests"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

Aug 2

David Chase (Gerrit), … Rachel (Gerrit)10

Aug 2

[arch] arch/internal: remove automatically generated tests

Rachel has created a revert of this change Open original change Related details Attention set is

unread,

[arch] arch/internal: remove automatically generated tests

Rachel has created a revert of this change Open original change Related details Attention set is

Aug 2

Gerrit Bot (Gerrit), … 나지원 (Gerrit)5

Aug 2

[sys] unix : fix Listen() on solaris

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Gerrit Bot uploaded new

unread,

[sys] unix : fix Listen() on solaris

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Gerrit Bot uploaded new

Aug 2

Gerrit Bot (Gerrit), … Nikita Shoshin (Gerrit)4

Aug 2

[tools] gopls/internal/golang/completion: don't make unnecessary conversions for generic functions

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

unread,

[tools] gopls/internal/golang/completion: don't make unnecessary conversions for generic functions

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

Aug 2

Alan Donovan (Gerrit), Robert Findley (Gerrit)3

Aug 2

[tools] go/packages/internal/linecount: add -nonblank flag

Attention needed from Alan Donovan Robert Findley added 2 comments File go/packages/internal/

unread,

[tools] go/packages/internal/linecount: add -nonblank flag

Attention needed from Alan Donovan Robert Findley added 2 comments File go/packages/internal/

Aug 2

Gerrit Bot (Gerrit), … t hepudds (Gerrit)10

Aug 2

[go] testing: allow specify temp dir by GOTMPDIR environment variable

Attention needed from Alan Donovan and Damien Neil t hepudds voted Commit-Queue+1 Commit-Queue +1

unread,

[go] testing: allow specify temp dir by GOTMPDIR environment variable

Attention needed from Alan Donovan and Damien Neil t hepudds voted Commit-Queue+1 Commit-Queue +1

Aug 2

Nicola Murino (Gerrit), … Bishakh Ghosh (Gerrit)4

Aug 2

[crypto] ssh: allow to bind to a hostname in remote forwarding

Attention needed from Filippo Valsorda and Nicola Murino Bishakh Ghosh voted and added 1 comment

unread,

[crypto] ssh: allow to bind to a hostname in remote forwarding

Attention needed from Filippo Valsorda and Nicola Murino Bishakh Ghosh voted and added 1 comment

Aug 2

Gerrit Bot (Gerrit), … Boris Kreitchman (Gerrit)22

Aug 2

[tools] go/analysis/passes/shadow: include filename in cross-file shadow error messages

Attention needed from Alan Donovan and Robert Findley Boris Kreitchman added 1 comment File go/

unread,

[tools] go/analysis/passes/shadow: include filename in cross-file shadow error messages

Attention needed from Alan Donovan and Robert Findley Boris Kreitchman added 1 comment File go/

Aug 2

Chris Zhang (Gerrit), … Michael Knyszek (Gerrit)10

Aug 2

[go] runtime: fix use-after-free issue in mutex profiling by removing raw frame pointer chasing

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt Chris Zhang added 2 comments

unread,

[go] runtime: fix use-after-free issue in mutex profiling by removing raw frame pointer chasing

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt Chris Zhang added 2 comments

Aug 2

Michael Knyszek (Gerrit)2

Aug 1

[go] runtime: disable stack shrinking for all waiting-for-suspendG cases

Attention needed from Michael Pratt Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] runtime: disable stack shrinking for all waiting-for-suspendG cases

Attention needed from Michael Pratt Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in

Aug 1

Gerrit Bot (Gerrit), … Jes Cok (Gerrit)5

Aug 1

[go] log/slog: add multiple handlers support for logger

Attention needed from Jonathan Amsterdam Jes Cok added 1 comment File src/log/slog/handler.go Line

unread,

[go] log/slog: add multiple handlers support for logger

Attention needed from Jonathan Amsterdam Jes Cok added 1 comment File src/log/slog/handler.go Line

Aug 1

Junyang Shao (Gerrit), David Chase (Gerrit)7

Aug 1

[arch] internal/simdgen: make bitwise logic avaialble to all u?int vectors

Attention needed from Cherry Mui and Junyang Shao David Chase added 1 comment File internal/simdgen/

unread,

[arch] internal/simdgen: make bitwise logic avaialble to all u?int vectors

Attention needed from Cherry Mui and Junyang Shao David Chase added 1 comment File internal/simdgen/

Aug 1

Junyang Shao (Gerrit), David Chase (Gerrit)5

Aug 1

[arch] internal/simdgen: change PairDotProdAccumulate to AddDotProd

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[arch] internal/simdgen: change PairDotProdAccumulate to AddDotProd

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

Aug 1

Junyang Shao (Gerrit), David Chase (Gerrit)7

Aug 1

[go/dev.simd] [dev.simd] cmd/compile, simd: change PairDotProdAccumulate to AddDotProd

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go/dev.simd] [dev.simd] cmd/compile, simd: change PairDotProdAccumulate to AddDotProd

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

Aug 1

Junyang Shao (Gerrit), David Chase (Gerrit)6

Aug 1

[go/dev.simd] [dev.simd] cmd/compile, simd: change Shift*AndFillUpperFrom to Shift*Concat

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go/dev.simd] [dev.simd] cmd/compile, simd: change Shift*AndFillUpperFrom to Shift*Concat

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

Aug 1

Junyang Shao (Gerrit), David Chase (Gerrit)4

Aug 1

[arch] internal/simdgen: change Shift*AndFillUpperFrom to Shift*Concat

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[arch] internal/simdgen: change Shift*AndFillUpperFrom to Shift*Concat

Attention needed from Junyang Shao David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

Aug 1

skewb1k (Gerrit), t hepudds (Gerrit)2

Aug 1

[tools] gopls/internal/analysis/modernize/forvar: provide fix for second loop var

Attention needed from skewb1k t hepudds voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related

unread,

[tools] gopls/internal/analysis/modernize/forvar: provide fix for second loop var

Attention needed from skewb1k t hepudds voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related

Aug 1

Junyang Shao (Gerrit)5

Aug 1

[go/dev.simd] [dev.simd] cmd/compile, simd: fix ShiftAll

Attention needed from Cherry Mui and David Chase Junyang Shao added 1 comment Patchset-level comments

unread,

[go/dev.simd] [dev.simd] cmd/compile, simd: fix ShiftAll

Attention needed from Cherry Mui and David Chase Junyang Shao added 1 comment Patchset-level comments

Aug 1

Junyang Shao (Gerrit)

Aug 1

[go/dev.simd] [dev.simd] cmd/compile: add ShiftAll imm variant optimization

Junyang Shao has uploaded the change for review Commit message [dev.simd] cmd/compile: add ShiftAll

unread,

[go/dev.simd] [dev.simd] cmd/compile: add ShiftAll imm variant optimization

Junyang Shao has uploaded the change for review Commit message [dev.simd] cmd/compile: add ShiftAll

Aug 1

Junyang Shao (Gerrit)

Aug 1

[arch] internal/simdgen: add ShiftAll imm variant optimization

Junyang Shao has uploaded the change for review Commit message internal/simdgen: add ShiftAll imm

unread,

[arch] internal/simdgen: add ShiftAll imm variant optimization

Junyang Shao has uploaded the change for review Commit message internal/simdgen: add ShiftAll imm

Aug 1

Dmitri Shuralyov (Gerrit)3

Aug 1

[build] internal/workflow: convert unexpected panics in tasks to task errors

Dmitri Shuralyov uploaded new patchset Dmitri Shuralyov uploaded patch set #2 to this change.

unread,

[build] internal/workflow: convert unexpected panics in tasks to task errors

Dmitri Shuralyov uploaded new patchset Dmitri Shuralyov uploaded patch set #2 to this change.

Aug 1

Junyang Shao (Gerrit), Cherry Mui (Gerrit)8

Aug 1

[go/dev.simd] [dev.simd] cmd/compile, simd: make bitwise logic ops available to all u?int vectors

Attention needed from Cherry Mui and David Chase Junyang Shao voted Commit-Queue+1 Commit-Queue +1

unread,

[go/dev.simd] [dev.simd] cmd/compile, simd: make bitwise logic ops available to all u?int vectors

Attention needed from Cherry Mui and David Chase Junyang Shao voted Commit-Queue+1 Commit-Queue +1

Aug 1

Junyang Shao (Gerrit)6

Aug 1

[arch] internal/simdgen: fix ShiftAll

Attention needed from Cherry Mui and David Chase Junyang Shao voted Commit-Queue+1 Commit-Queue +1

unread,

[arch] internal/simdgen: fix ShiftAll

Attention needed from Cherry Mui and David Chase Junyang Shao voted Commit-Queue+1 Commit-Queue +1

Aug 1

Search

Clear search

Close search

Google apps

Main menu